Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-query): Add usePrefetchQueries hook #8734

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(react-query): Add usePrefetchQueries hook #8734

wants to merge 9 commits into from

Conversation

DogPawHat
Copy link
Contributor

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 2, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ad28506.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 51s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 33s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-12 16:09:18 UTC

@DogPawHat DogPawHat force-pushed the prefetch-queries-hook branch from b3564b1 to 90802bc Compare March 2, 2025 10:52
@DogPawHat DogPawHat changed the title [feat(react-query)] Add usePrefetchQueries hook feat(react-query): Add usePrefetchQueries hook Mar 2, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 2, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8734

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8734

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8734

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8734

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8734

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8734

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8734

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8734

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8734

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8734

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8734

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8734

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8734

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8734

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8734

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8734

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8734

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8734

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8734

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8734

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8734

commit: ad28506

@codecov Codecov
Copy link

codecov bot commented Mar 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.96%. Comparing base (4a89814) to head (ad28506).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8734       +/-   ##
===========================================
+ Coverage   46.37%   84.96%   +38.58%     
===========================================
  Files         199       27      -172     
  Lines        7551      379     -7172     
  Branches     1730      112     -1618     
===========================================
- Hits         3502      322     -3180     
+ Misses       3669       49     -3620     
+ Partials      380        8      -372
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 96.15% <100.00%> (+0.72%) ⬆️
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DogPawHat DogPawHat force-pushed the prefetch-queries-hook branch from 90802bc to cfc4a49 Compare March 3, 2025 15:55
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 5, 2025
TkDodo
TkDodo reviewed Mar 11, 2025
View reviewed changes
packages/react-query/src/usePrefetchQueries.tsx Outdated
Comment on lines 4 to 9
export function usePrefetchQueries(
options: {
queries: ReadonlyArray<FetchQueryOptions<any, any, any, any>>
},
queryClient?: QueryClient,
) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is FetchQueryOptions<any, any, any, any> really good enough here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted out the rather through recursive SuspenseQueriesOptions recursive type reducer from useSuspenseQueries and modified it for using FetchQueryOptions in this case. Although were not gonna be using all that type information in this case at this point.

@DogPawHat DogPawHat force-pushed the prefetch-queries-hook branch from 4b70794 to f8860e5 Compare March 12, 2025 12:17
@DogPawHat DogPawHat force-pushed the prefetch-queries-hook branch from f8860e5 to 75ba89f Compare March 12, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DogPawHat @TkDodo